Attention is currently required from: Ashish Kumar Mishra, Jérémy Compostella, Paul Menzel, Subrata Banik, Wonkyu Kim.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80088?usp=email )
Change subject: cpu/x86: Add 1GiB pages for memory access up to 512GiB
......................................................................
Patch Set 7:
(3 comments)
File src/cpu/x86/64bit/pt1G.S:
https://review.coreboot.org/c/coreboot/+/80088/comment/db728e36_215e8503 :
PS7, Line 21: 32
actually this needs to be 4096 too. The lower 12 bits of cr0 are not be used.
https://review.coreboot.org/c/coreboot/+/80088/comment/2de5593b_4f64ee6e :
PS7, Line 27: 512
I some size constrained cases a different number is nice. I suppose making this configurable could be done in a follow-up.
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/80088/comment/d082bd66_b1ca58e1 :
PS7, Line 158: pages
add a '.' at the end.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80088?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id569ae5b50abf5b72e4db33b5e4cd802399e76ec
Gerrit-Change-Number: 80088
Gerrit-PatchSet: 7
Gerrit-Owner: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 06 Feb 2024 07:52:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment