Yuchen He has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76035?usp=email )
Change subject: mb/{cfl,cml,whl}: Use true/false macros for DdiPortDDdc dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for DdiPortDDdc dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="DdiPortDDdc" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: I73cf64609af626de421a2ae8253273d40d9d2faa Signed-off-by: lilacious yuchenhe126@gmail.com --- M src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb M src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/76035/1
diff --git a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb index d8eb751..aaf0349 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/cml_u/overridetree.cb @@ -12,7 +12,7 @@ # Enable DDC for DDI ports B/C register DdiPortBDdc = true register DdiPortCDdc = true - register "DdiPortDDdc" = "1" + register DdiPortDDdc = true register "DdiPortFDdc" = "1"
register "SerialIoDevMode" = "{ diff --git a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb index e155bdd..eec7c79 100644 --- a/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb +++ b/src/mainboard/intel/coffeelake_rvp/variants/whl_u/overridetree.cb @@ -12,7 +12,7 @@ # Enable DDC for DDI ports B/C/D/F register DdiPortBDdc = true register DdiPortCDdc = true - register "DdiPortDDdc" = "1" + register DdiPortDDdc = true register "DdiPortFDdc" = "1"
register SataSalpSupport = true