Attention is currently required from: Arthur Heymans, Jérémy Compostella, Nico Huber.
Angel Pons has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84040?usp=email )
Change subject: ext_stage_cache: Make sure variables are initialized ......................................................................
Patch Set 7: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84040/comment/342f7e49_ff66d73d?usp... : PS7, Line 10:
Maybe add: `Also exit gracefully from stage-cache code if no smm region is found.` […]
Can the stage cache be disabled?
File src/cpu/x86/smm/tseg_region.c:
https://review.coreboot.org/c/coreboot/+/84040/comment/28e6a77c_57ca28d8?usp... : PS7, Line 34: return -1;
Hmmm, do we ever link this path? Because here start/size would […]
+1
File src/lib/ext_stage_cache.c:
https://review.coreboot.org/c/coreboot/+/84040/comment/3734cdfc_bb87d109?usp... : PS7, Line 18: stage_cache_external_region(&base, &size); : if (base == NULL || size == 0) : return; Would it make sense to return status from `stage_cache_external_region()`?
```suggestion if (stage_cache_external_region(&base, &size)) return; ```