Attention is currently required from: Saurabh Mishra, Subrata Banik.
Krishna P Bhat D has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83732?usp=email )
Change subject: vc/intel/fsp/fsp2_0/ptl: Add placeholder FSP headers to compile
......................................................................
Patch Set 8:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83732/comment/0b034369_78d962ed?usp... :
PS8, Line 10: - Skeleton files to complie google/fatcat mainboard.
nit: compile
File src/vendorcode/intel/fsp/fsp2_0/pantherlake/FirmwareVersionInfo.h:
https://review.coreboot.org/c/coreboot/+/83732/comment/06a08b27_61c1de3a?usp... :
PS8, Line 69:
Remove the additional blank line at the end of all header files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83732?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4c069ba64f487259ce746dc52296618d91209602
Gerrit-Change-Number: 83732
Gerrit-PatchSet: 8
Gerrit-Owner: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-CC: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Bora Guvendik
bora.guvendik@intel.com
Gerrit-CC: Hannah Williams
hannah.williams@intel.com
Gerrit-CC: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-CC: Vikrant L Jadeja
vikrant.l.jadeja@intel.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Comment-Date: Sat, 03 Aug 2024 17:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No