Attention is currently required from: Michał Żygowski, Martin Roth, Igor Bagnucki, Stefan Reinauer, Krystian Hebel, Timothy Pearson.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58656 )
Change subject: payloads/external: add skiboot (for QEMU/Power9)
......................................................................
Patch Set 14:
(2 comments)
File payloads/external/skiboot/Kconfig:
https://review.coreboot.org/c/coreboot/+/58656/comment/5a690724_421dd8e6
PS14, Line 10: default "https://gitlab.com/qemu-project/skiboot.git" if BOARD_EMULATION_QEMU_POWER9
Does it have to be a special QEMU repo? I would rather want to avoid specifying repo address.
The one at https://git.raptorcs.com/git/talos-skiboot doesn't work with QEMU and it's specified on our development branch, which is why I made URL configurable. The GitLab repo is in sync with https://github.com/open-power/skiboot, by the way.
File src/mainboard/emulation/qemu-power9/Kconfig:
https://review.coreboot.org/c/coreboot/+/58656/comment/d4f3d01b_065fbedc
PS14, Line 11: select BOARD_ROMSIZE_KB_1024
Is it a sane value when skiboot is included?
Yes, compressed skiboot fits in 1 MiB along with coreboot. If you want to make it more future proof, can make it 2 MiB.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58656
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b49ea7464c97cc2ff0d5030629deed549851372
Gerrit-Change-Number: 58656
Gerrit-PatchSet: 14
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Igor Bagnucki
igor.bagnucki@3mdeb.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Igor Bagnucki
igor.bagnucki@3mdeb.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 14:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment