Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Martin Roth, Tim Van Patten.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75583?usp=email )
Change subject: mb/google/myst: Add PCIe shutdown workaround
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/google/myst/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/75583/comment/0d4e6a07_848d79ca :
PS2, Line 56: .turn_off_unused_lanes = true,
Can we toggle this to `false` instead, assuming that also fixes it? It seems like a more direct appr […]
This is a workaround and it's working. We have a bug to track getting it fixed. I think this is fine as is.
https://review.coreboot.org/c/coreboot/+/75583/comment/5b5a0b9f_56cbd4cd :
PS2, Line 57: /284213391
nit: b/284213391 (missing the 'b'), for both of these
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75583?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf0aca329f05f15a3ce9edfa6a0e782c2edccabe
Gerrit-Change-Number: 75583
Gerrit-PatchSet: 3
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 01 Jun 2023 21:10:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment