Attention is currently required from: Stefan Ott, Bill XIE, Arthur Heymans, Alexander Couzens.
Swift Geek (Sebastian Grzywna) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74418 )
Change subject: mb/lenovo/x200: Configure ck505 clockgen
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/lenovo/x200/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74418/comment/599ff14f_a45b0d4f
PS5, Line 16: set_gpio(42, GPIO_LEVEL_LOW);
Would it be feasible to restore here state captured in start of ck505_set_mux_enable(), instead of hardcoding it ?
That i2c bus switch in thinkpad is already causing enough issues for memtest86+ and other users, so I think it would be better if code wouldn't depend on particular expectation there for default state of the switch, as it would make eventual switch a bit be easier perhaps.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74418
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec9bbbaed43b74e8782f6963e491dbfa3b8b5247
Gerrit-Change-Number: 74418
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Fri, 14 Apr 2023 19:20:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment