13 Nov
2021
13 Nov
'21
12:41 a.m.
Attention is currently required from: Varshit B Pandya, Chen Wisley. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59260 )
Change subject: mb/google/brya/var/redrix: Configure _DSC for CAM devices to ACPI_DEVICE_SLEEP_D3_COLD ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/redrix/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59260/comment/aee1d9e5_5ee04d0e PS2, Line 346: ACPI_DEVICE_SLEEP_D3_COLD Maybe I'm confused, should the NVM also have the _DSC set to D3cold? this one you want to actually put into D0 to probe?
--
To view, visit https://review.coreboot.org/c/coreboot/+/59260
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88ea1b87698c63e1bd69367ee857fba3f25c84ea
Gerrit-Change-Number: 59260
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Reviewer: Chen Wisley wisley.chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Rizwan Qureshi rizwan.qureshi@intel.com
Gerrit-Attention: Varshit B Pandya varshit.b.pandya@intel.com
Gerrit-Attention: Chen Wisley wisley.chen@quantatw.com
Gerrit-Comment-Date: Fri, 12 Nov 2021 23:41:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment