Attention is currently required from: Paul Menzel, Weimin Wu, Zhi7 Li.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
Please rebase this change on top of CB:56930
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56804/comment/e0a98dee_19a3388a
PS10, Line 7: EXT_VR
dont capitalize in between. Keep them all small letters.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 10
Gerrit-Owner: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Zhi7 Li
lizhi7@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 16 Aug 2021 16:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment