Attention is currently required from: Angel Pons, Lean Sheng Tan, Maximilian Brune, Paul Menzel, Tim Wawrzynczak.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66545?usp=email )
Change subject: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC ......................................................................
Patch Set 21:
(3 comments)
File src/mainboard/intel/adlrvp/variants/adlrvp_s_ddr5_udimm_1dpc/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/66545/comment/4689e31d_715508ad : PS21, Line 3: # Configure overcurrent for USB Ports : register "usb2_ports[6]" = "USB2_PORT_MID(OC7)" # USB3/2 Type A port7 : register "usb2_ports[9]" = "USB2_PORT_MID(OC7)" # USB3/2 Type A port10 : register "usb2_ports[10]" = "USB2_PORT_MID(OC0)" # USB3/2 Type A port11 : register "usb2_ports[12]" = "USB2_PORT_MID(OC0)" # USB3/2 Type A port13 Move these to XHCI controller in devicetree
https://review.coreboot.org/c/coreboot/+/66545/comment/dd7abdca_757b63fe : PS21, Line 9: #TODO check in 723858 if they are similar for all ADLRVP-S boards : # DDI_PORT_A: Combo PHY A # ADL-S RVP UDIMM 1DPC eDP1.4 Connector : # DDI_PORT_1: Combo PHY B # ADL-S RVP UDIMM 1DPC HDMI 1.4b CRLS : # DDI_PORT_2: Combo PHY C # ADL-S RVP UDIMM 1DPC DP1.4a Connector : # DDI_PORT_3: Combo PHY D # ADL-S RVP UDIMM 1DPC HDMI 2.0b ALS : # DDI_PORT_4: Combo PHY E # ADL-S RVP UDIMM 1DPC DP1.4a Connector : # Enable eDP in PortA #TODO test : #register "ddi_portA_config" = "1" : #[DDI_PORT_A] = DDI_ENABLE_HPD : register "ddi_ports_config" = "{ : [DDI_PORT_1] = DDI_ENABLE_HPD, : [DDI_PORT_2] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, : [DDI_PORT_3] = DDI_ENABLE_HPD, : [DDI_PORT_4] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, : }" Move to iGPU controller in devicetree
https://review.coreboot.org/c/coreboot/+/66545/comment/d9e2ab07_2d89e266 : PS21, Line 25: register "sata_salp_support" = "1" : register "sata_ports_enable" = "{ : [4] = 1, : [5] = 1, : [6] = 1, : [7] = 1, : }" : : register "sata_ports_dev_slp" = "{ : [4] = 0, : [5] = 0, : [6] = 1, : [7] = 1, : }" Move to SATA controller in devicetree