Attention is currently required from: Tim Wawrzynczak, Zhuohao Lee, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60274 )
Change subject: soc/intel/common/block/gpio: add variant_gpio_lock_config() ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Yes, but that is also how we handle, e.g., GPIOs. […]
To do that, we either change the api for mb_gpio_lock_config() to allow a second list ptr to be passed back, or we have to allocate memory in mb_gpio_lock_config() to hold both mb and variant list, concatenate them there and pass the pointer back from mb_gpio_lock_config(), but then caller of mb_gpio_lock_config() must free the memory after locking the list of gpios.
Non-optimal issue with that is that if variant doesn't export a list, mb_gpio_lock_config() will still need to allocate a block of memory and copy its own list into it.
Thoughts on the best / most efficient way to implement this?