Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48287 )
Change subject: soc/amd/picasso/tsc: fix clock divisor range check
......................................................................
Patch Set 1: Code-Review+2
I'm OK with the change. However I'd convinced Nick to put it the way it was in CB:45055 in case a new did became unreserved, i.e. it looks like the reserved values are merely unused, not unsupportable. Since we're reading what's already in the register, I'd err on the side of interpreting it if possible. (And an error message is OK too.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ee342d22294044a68d2f4b2484c50f9e345196
Gerrit-Change-Number: 48287
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 04 Dec 2020 01:29:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment