Attention is currently required from: Andrey Pronin, Christian Walter, Tim Wawrzynczak, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59134 )
Change subject: security/tpm/tcg-2.0: Handle TPM_RC_NV_RANGE return code
......................................................................
Patch Set 2:
(1 comment)
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/59134/comment/20651f3a_09bbc2c2
PS2, Line 246: return TPM_E_READ_EMPTY;
How about TPM_E_READ_TOO_LARGE or TPM_E_REQUEST_TOO_LARGE?
Why not just TPM_E_RANGE to match what it's called in the spec? (But either name is fine, I'm just saying it shouldn't overload the one that already means something else.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59134
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b403e2f33cc1368065cc21f73df1102695f73eb
Gerrit-Change-Number: 59134
Gerrit-PatchSet: 2
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 18:53:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment