Attention is currently required from: Arthur Heymans, Christian Walter, Jeremy Soller, Paul Menzel, Philipp Deppenwiese.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73297?usp=email )
Change subject: security/tpm/tspi/log: Respect CBMEM TPM log size when copying preram entries
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73297/comment/e429a4e1_a3667a8c :
PS4, Line 11: cmbem
CBMEM
Done
Patchset:
PS1:
The sanity check is fine but the dealing with S3 resume needs to be fixed differently. […]
Okay, but this change is about preventing logs from clobbering CBMEM when being copied. It's obvious to hit right now *because* S3 resume does remeasure, but if that's fixed are you saying this check is not needed at all?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73297?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If76299e68eb5ed2ed20c947be35cea46c51fcdec
Gerrit-Change-Number: 73297
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Crawford
tcrawford@system76.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Attention: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 21 Jun 2023 14:44:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment