Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42331 )
Change subject: mb/google/volteer: update volteer cbi definition
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42331/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/42331/1/src/mainboard/google/voltee...
PS1, Line 7: DB_USB3_PASSIVE
@willam, thanks - keeping these assignments consistent between baseboard and variants […]
These field options should really be defined in program/volteer/program.star in order to go in baseboard/devicetree.cb and if it is only defined in the project/volteer/config.star then we should be defining the options in overridetree.cb. (but I don't think that is what we want and that isn't going to work for the EC anyway)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I761893818231880d86fd13cfa61319157d06a7d5
Gerrit-Change-Number: 42331
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jes Klinke
jbk@google.com
Gerrit-Reviewer: William Wei
wenxu.wei@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xiong Huang
xiong.huang@bitland.corp-partner.google.com
Gerrit-Comment-Date: Tue, 16 Jun 2020 17:24:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: William Wei
wenxu.wei@bitland.corp-partner.google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment