Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31473 )
Change subject: drivers/spi/spi_flash.c: Avoid static scan false positive ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/31473/1/src/drivers/spi/spi_flash.c File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/#/c/31473/1/src/drivers/spi/spi_flash.c@199 PS1, Line 199: ; If this is set to -1 here, wouldn't it make the static checker happy?
https://review.coreboot.org/#/c/31473/1/src/drivers/spi/spi_flash.c@207 PS1, Line 207: < len is of type size_t. How does it end up being less than 0?
https://review.coreboot.org/#/c/31473/1/src/drivers/spi/spi_flash.c@214 PS1, Line 214: offset Isn't offset the same as start? I don't understand the change here?