7 Dec
2021
7 Dec
'21
8:10 a.m.
Attention is currently required from: SH Kim, Tim Wawrzynczak, Gwendal Grignou. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59608 )
Change subject: driver/i2c: Add sx9360 driver ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59608/comment/7872724b_ea3e1ab5 PS3, Line 12: Documentation/devicetree/bindings/iio/proximity/semtech,sx9360.yaml That’s not yet in Linus’ master branch?
File src/drivers/i2c/sx9360/sx9360.c:
PS2:
It is actually closer to sx9310 current driver. […]
Good point. Please mention in the commit message, what code you took as base.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59608
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a912f184e6f3501f894cca24c0d71a2c3087516
Gerrit-Change-Number: 59608
Gerrit-PatchSet: 3
Gerrit-Owner: Gwendal Grignou gwendal@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: SH Kim sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: SH Kim sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Gwendal Grignou gwendal@chromium.org
Gerrit-Comment-Date: Tue, 07 Dec 2021 08:10:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Gwendal Grignou gwendal@chromium.org
Gerrit-MessageType: comment