Attention is currently required from: Tim Wawrzynczak, Angel Pons, Werner Zeh, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61519 )
Change subject: soc/intel/common/cse: Add `cse_send_end_of_post()` as a public function
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/61519/comment/974f9608_4d1ecaed
PS9, Line 188: static void set_cse_end_of_post(void *unused)
: {
: static bool eop_sent = false;
: /*
: * If CSE is already hidden then accessing CSE registers would be wrong and will
: * receive junk, hence, return as CSE is already disabled.
: */
: if (!is_cse_enabled()) {
: printk(BIOS_DEBUG, "CSE is disabled, cannot send End-of-Post (EOP) message\n");
: return;
: }
:
: if (eop_sent) {
: printk(BIOS_ERR, "EOP already sent\n");
: return;
: }
:
: set_cse_device_state(PCH_DEVFN_CSE, DEV_ACTIVE);
:
: timestamp_add_now(TS_ME_BEFORE_END_OF_POST);
: handle_cse_eop_result(cse_send_eop());
: timestamp_add_now(TS_ME_AFTER_END_OF_POST);
:
: set_cse_device_state(PCH_DEVFN_CSE, DEV_IDLE);
:
: eop_sent = true;
: }
:
: void cse_send_end_of_post(void)
: {
: return set_cse_end_of_post(NULL);
: }
second to Tim.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61519
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I837c5723eca766d21b191b98e39eb52889498bfc
Gerrit-Change-Number: 61519
Gerrit-PatchSet: 9
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Feb 2022 06:34:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment