Attention is currently required from: Angel Pons.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83184?usp=email )
Change subject: util/autoport: Make printing of SPDX headers generic ......................................................................
Patch Set 3:
(2 comments)
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83184/comment/d28612d5_4103da9a?usp... : PS2, Line 882: gma.WriteString(`-- SPDX-License-Identifier: GPL-2.0-or-later
Of course, the function would be renamed to `Add_License` or similar. […]
Done
https://review.coreboot.org/c/coreboot/+/83184/comment/63103b8e_9bef77b0?usp... : PS2, Line 232: func Add_gpl(f *os.File, filetype Filetype) { : fmt.Fprintf(f, CommentFormatStrings[filetype], : "SPDX-License-Identifier: GPL-2.0-only") : fmt.Fprintln(f) : }
Acknowledged. There is already a `makeComment()` function in `main. […]
Done. Left makeComment as is for now and will probably drop it and change the Kconfig comment handling in a separate commit.