[coreboot-gerrit] [XS] Change in coreboot[main]: mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)

[Subrata Banik (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Nick Vaccaro, Rishika Raj.

Subrata Banik has posted comments on this change by Nick Vaccaro. ( https://review.coreboot.org/c/coreboot/+/83932?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: mb/goog/brya: Don't lock GPP_F15 (FPMCU_INT_L)
......................................................................

Patch Set 3: Code-Review+2

(1 comment)

Patchset:

PS3: 
With commit CB:64089, we now program the GPE Enable bit for all SCI pins during boot. This means that if there is any GPE status active for any pin, we won't be able to clear it. Because these bits are sticky bits and are cleared by writing a 1 back to this bit position, being unable to clear pending GPE status would result in a fake wake when GPE EN for the PAD is enabled and the last GPE hasn't been cleared. By removing the lock, coreboot can now clear the GPE status during boot to avoid a fake wake.

To prove this point, let's dump the GPE status without this CL during boot and before issuing the poweroff operation from depthcharge. This will prove that the last GPE status was causing this fake wake.