Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board
......................................................................
Patch Set 68:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35864/67/Documentation/mainboard/le...
File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/67/Documentation/mainboard/le...
PS67, Line 3: https://i.imgur.com/jkD0Bou.jpg
1) it's a link. Please embed if you want it in here.
2) I don't think this is a useful image. It is not referenced in the guide.
https://review.coreboot.org/c/coreboot/+/35864/67/Documentation/mainboard/le...
PS67, Line 14: The flash chip is U49
"The flash chip is referenced as U49 in the schematics and in the boardview." ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd9208a5eafd228f8eedbc8fb4f4eb9ed1932a14
Gerrit-Change-Number: 35864
Gerrit-PatchSet: 68
Gerrit-Owner: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maccraft123
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 25 Oct 2019 18:38:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment