[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: set use of legacy 8254 timer

[Jeremy Soller (Code Review)]

Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33512 )

Change subject: soc/intel/cannonlake: set use of legacy 8254 timer
......................................................................

Patch Set 1:
> Patch Set 1:
> > I'll double check if it's needed for Tianocore as well.
>
> Tiano booted just fine with USE_LEGACY_8254_TIMER=y and TIANOCORE_USE_8254_TIMER=n

Cool, that's good
> The FSP integration guide says "Make sure [Enable8254ClockGating] is disabled to
> support boot legacy OS using 8254 timer" -- so perhaps the Kconfig should be 'DISABLE_LEGACY_8254_TIMER' vs 'USE_LEGACY_8254_TIMER' or something to that effect?

Yep. I also recommend removing the if COFFEELAKE || WHISKEYLAKE condition and only relying on the SeaBIOS condition, to satisfy Nico's comment.

CometLake will also require it.