build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43678 )
Change subject: soc/amd/picasso: Don't run dcache_clean_all() in psp_verstage ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43678/3/src/lib/reset.c File src/lib/reset.c:
https://review.coreboot.org/c/coreboot/+/43678/3/src/lib/reset.c@9 PS3, Line 9: __weak int run_dcache_clean_in_board_reset() { Bad function definition - __weak int run_dcache_clean_in_board_reset() should probably be __weak int run_dcache_clean_in_board_reset(void)
https://review.coreboot.org/c/coreboot/+/43678/3/src/lib/reset.c@9 PS3, Line 9: __weak int run_dcache_clean_in_board_reset() { open brace '{' following function definitions go on the next line
https://review.coreboot.org/c/coreboot/+/43678/3/src/soc/amd/picasso/psp_ver... File src/soc/amd/picasso/psp_verstage/reset.c:
https://review.coreboot.org/c/coreboot/+/43678/3/src/soc/amd/picasso/psp_ver... PS3, Line 11: int run_dcache_clean_in_board_reset() { Bad function definition - int run_dcache_clean_in_board_reset() should probably be int run_dcache_clean_in_board_reset(void)
https://review.coreboot.org/c/coreboot/+/43678/3/src/soc/amd/picasso/psp_ver... PS3, Line 11: int run_dcache_clean_in_board_reset() { open brace '{' following function definitions go on the next line