build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32097 )
Change subject: WIP: mediaek/mt8183: add panel driver for kukui p2 ......................................................................
Patch Set 1:
(52 comments)
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 82: gpio_set_pull(GPIO(MISC_BSI_CK_3), GPIO_PULL_ENABLE, GPIO_PULL_UP); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 83: gpio_set_pull(GPIO(PERIPHERAL_EN9), GPIO_PULL_ENABLE, GPIO_PULL_UP); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 117: printk(BIOS_ERR, "aaadump_gpio_reg : reg[ox350] = 0x%x\n", read32((void *)GPIO_BASE + 0x350)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 118: printk(BIOS_ERR, "aaadump_gpio_reg : reg[ox10] = 0x%x\n", read32((void *)GPIO_BASE + 0x10)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 119: printk(BIOS_ERR, "aaadump_gpio_reg : reg[ox110] = 0x%x\n", read32((void *)GPIO_BASE + 0x110)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 121: printk(BIOS_ERR, "aaadump_gpio_reg : reg[ox390] = 0x%x\n", read32((void *)GPIO_BASE + 0x390)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 122: printk(BIOS_ERR, "aaadump_gpio_reg : reg[ox20] = 0x%x\n", read32((void *)GPIO_BASE + 0x20)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 123: printk(BIOS_ERR, "aaadump_gpio_reg : reg[ox120] = 0x%x\n", read32((void *)GPIO_BASE + 0x120)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 166: {INIT_CMD, 2, {0xff, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 169: {INIT_CMD, 6, {0x00, 0x08, 0x01, 0xf4, 0x01, 0x49}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 171: {INIT_CMD, 6, {0x00, 0x0c, 0x00, 0x00, 0x00, 0x03}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 174: {INIT_CMD, 6, {0x00, 0x14, 0x0c, 0x3d, 0x80, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 175: {INIT_CMD, 6, {0x00, 0x20, 0x15, 0x92, 0x56, 0x7d}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 176: {INIT_CMD, 6, {0x00, 0x24, 0x00, 0x00, 0x30, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 181: {INIT_CMD, 6, {0x10, 0x08, 0x01, 0x20, 0x04, 0x45}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 182: {INIT_CMD, 6, {0x10, 0x1c, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 183: {INIT_CMD, 6, {0x20, 0x0c, 0x00, 0x00, 0x00, 0x04}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 185: {INIT_CMD, 6, {0x20, 0x10, 0x00, 0x4b, 0x00, 0x49}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 186: {INIT_CMD, 6, {0x20, 0xa0, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 188: {INIT_CMD, 6, {0x60, 0x08, 0x00, 0xd9, 0x00, 0x08}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 189: {INIT_CMD, 6, {0x60, 0x14, 0x01, 0x00, 0x01, 0x06}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 191: {INIT_CMD, 6, {0x60, 0x80, 0x00, 0x00, 0x00, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 193: {INIT_CMD, 6, {0x60, 0xa0, 0x00, 0x00, 0x00, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 196: {INIT_CMD, 6, {0x60, 0x0c, 0x0c, 0x50, 0x02, 0x18}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 198: {INIT_CMD, 6, {0x60, 0x10, 0x08, 0x00, 0x14, 0x50}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 200: {INIT_CMD, 6, {0x60, 0x84, 0x00, 0x00, 0x03, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 201: {INIT_CMD, 6, {0x60, 0xa4, 0x00, 0x00, 0x03, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 204: {INIT_CMD, 2, {0xff, 0x01}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 205: {INIT_CMD, 1, {0x11}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 206: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 207: {INIT_CMD, 1, {0x29}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 208: {DELAY_CMD, 20, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 209: {INIT_CMD, 2, {0xff, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 213: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 214: {INIT_CMD, 1, {0x11}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 215: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 216: {INIT_CMD, 1, {0x29}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 217: {DELAY_CMD, 20, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 243: false, &edid, lcm_init_cmd, sizeof(lcm_init_cmd) / sizeof(struct lcm_init_table)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/mainboard/google/kukui/mainboard... PS1, Line 246: false, &edid, lcm_p097pfg_ssd2858_init_cmd, sizeof(lcm_p097pfg_ssd2858_init_cmd) / sizeof(struct lcm_init_table)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@371 PS1, Line 371: while(read32(&dsi->dsi_intsta) & (1 << 31)) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@372 PS1, Line 372: printk(BIOS_ERR, "mtk_dsi_cmdq wait dsi no busy\n"); Prefer using '"%s...", __func__' to using 'mtk_dsi_cmdq', this function's name, in a string
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@376 PS1, Line 376: printk(BIOS_ERR, "mtk_dsi_cmdq dsi no busy\n"); Prefer using '"%s...", __func__' to using 'mtk_dsi_cmdq', this function's name, in a string
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@417 PS1, Line 417: dsi_clrsetbits_le32((void *)DSI_BASE + 0x200 + ((cmdq_off + i) & (0xfffffffc)), line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@438 PS1, Line 438: printk(BIOS_ERR, "dump_dsi_reg : reg[0x%x] = 0x%x\n", i, read32((void *)DSI_BASE + i)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@440 PS1, Line 440: printk(BIOS_ERR, "xxxdump_dsi_reg : reg[0x60] = 0x%x\n", read32((void *)DSI_BASE + 0x60)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@441 PS1, Line 441: printk(BIOS_ERR, "xxxdump_dsi_reg : reg[0x00] = 0x%x\n", read32((void *)DSI_BASE)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@442 PS1, Line 442: printk(BIOS_ERR, "xxxdump_dsi_reg : reg[0x14] = 0x%x\n", read32((void *)DSI_BASE + 0x14)); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@464 PS1, Line 464: printk(BIOS_ERR, "delay : init_cmd[%d].len = 0x%x\n", i, init_cmd[i].len); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@472 PS1, Line 472: printk(BIOS_ERR, "init_cmd : init_cmd[%d].data[0] = 0x%x\n", i, init_cmd[i].data[0]); line over 80 characters
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@505 PS1, Line 505: for (i = 0; i < 0x208; i = i + 4) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/32097/1/src/soc/mediatek/mt8183/dsi.c@506 PS1, Line 506: printk(BIOS_ERR, "dump_dsi_reg : reg[ox%x] = 0x%x\n", i, read32((void *)DSI_BASE + i)); line over 80 characters