2 Jun
2020
2 Jun
'20
4:17 p.m.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42022 )
Change subject: mb/facebook/watson: support firmware version ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42022/1/src/mainboard/facebook/wats... File src/mainboard/facebook/watson/ramstage.c:
https://review.coreboot.org/c/coreboot/+/42022/1/src/mainboard/facebook/wats... PS1, Line 38: static char cb_ver[] = "cb_ver:";
static char array declaration should probably be static const char
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/42022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: 4.11_branch
Gerrit-Change-Id: I831fe7019ddd75beb6824b8e09445f339bf7cc8d
Gerrit-Change-Number: 42022
Gerrit-PatchSet: 2
Gerrit-Owner: Jonathan Zhang jonzhang@fb.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jun 2020 23:17:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins) no-reply@coreboot.org
Gerrit-MessageType: comment