Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34207 )
Change subject: nb/amd/amdmct/mct: Fix condition that has identical branches
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34207/1/src/northbridge/amd/amdmct/...
File src/northbridge/amd/amdmct/mct/mctardk4.c:
https://review.coreboot.org/c/coreboot/+/34207/1/src/northbridge/amd/amdmct/...
PS1, Line 121: if (MAAload == 4 || MAAload == 16)
This might look nicer with switch statement. Or for documentation purposes otherwise show clearly which path MAAload == 8 takes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34207
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie5ee2e2527c6745381c7bdd2cbe3212fdd28e8ba
Gerrit-Change-Number: 34207
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 11 Jul 2019 02:18:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment