Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36089 )
Change subject: mb/google/kukui: Skip fast calibration in recovery mode
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36089/2/src/soc/mediatek/mt8183/mem...
File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/36089/2/src/soc/mediatek/mt8183/mem...
PS2, Line 167: vboot_recovery_mode_enabled
Done
This is already handled -- vboot_recovery_mode_enabled() and similar functions just always return 0 when vboot is not enabled. You don't need to worry about this... x86 uses it this was as well (checking those functions from right within their SoC memory training code). I think putting them here makes more sense.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36089
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29e0df71dc3357462e15ce8fc2ba02f21b54ed33
Gerrit-Change-Number: 36089
Gerrit-PatchSet: 5
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 19 Oct 2019 02:28:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment