Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Qinghong Zeng.
Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/83408?usp=email )
Change subject: mb/google/nissa: Create teliks variant
......................................................................
Patch Set 16:
(1 comment)
File src/mainboard/google/brya/variants/teliks/data.vbt:
PS16:
If this file is missing, the compilation will prompt: (make: *** No rule to make target "src/mainboard/google/brya/variants/teliks/data.vbt", needed by "coreboot-builds/GOOGLE_TELIKS/coreboot.pre". Stop.) and then the compilation will fail.
can you please check if you are able to override the below Kconfig from config.teliks
```
CONFIG_INTEL_GMA_VBT_FILE="3rdparty/blobs/mainboard/google/brya/vbt.bin"
```
I'm sensing somehow you are unable to override this Kconfig hence, it's tries to fill the Kconfig from coreboot log
```
config INTEL_GMA_VBT_FILE
string "VBT binary path and filename"
depends on INTEL_GMA_ADD_VBT
default "src/mainboard/$(MAINBOARDDIR)/variants/$(VARIANT_DIR)/data.vbt" \
if INTEL_GMA_HAVE_VBT && VARIANT_DIR != ""
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83408?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I744f4d7c2d35544d3a8a8f76e24bad3298442768
Gerrit-Change-Number: 83408
Gerrit-PatchSet: 16
Gerrit-Owner: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 30 Jul 2024 07:55:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com