Attention is currently required from: Arthur Heymans, Raul Rangel, Nico Huber.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58603 )
Change subject: [RFC]cpu/x86/mp_init.c: Copy BSP chip_info to AP devices
......................................................................
Patch Set 1:
(1 comment)
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/c/coreboot/+/58603/comment/8d4c06d8_636a1207
PS1, Line 392: new->chip_info = info->cpu->chip_info;
I was more wondering if you should check `new->chip_info == NULL` before overriding the value.
I analyzed the cases where `new->chip_info` would be non-null, and concluded that it's very unusual and unlikely to happen anytime soon. I think adding the check is a good idea, and it wouldn't make a difference most (if not all) cases.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58603
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b9b83b096da07821b7c1f9b36b3e311cd751718
Gerrit-Change-Number: 58603
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 17 Nov 2021 15:25:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment