Attention is currently required from: AlanKY Lee, Tarun Tuli.
Mac Chiang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76925?usp=email )
Change subject: mb/google/brya/var/brya0: add nau8318 speaker support ......................................................................
Patch Set 5:
(7 comments)
File src/mainboard/google/brya/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/76925/comment/aed98bdb_3b4869a1 : PS5, Line 47: select DRIVERS_I2C_NAU8825 No need here. Because BRYA_COMMON already picked it up for variants.
https://review.coreboot.org/c/coreboot/+/76925/comment/e9fc80b8_8a495067 : PS5, Line 150: select DRIVERS_I2C_NAU8825 No need herer. Because the BRYA_COMMON already pick it up for variants
File src/mainboard/google/brya/variants/brya0/fw_config.c:
https://review.coreboot.org/c/coreboot/+/76925/comment/61c3f2fb_bc18f6cf : PS5, Line 42: static const struct pad_config nau8318_enable_pads[] = { remove these. Let's reuse max98360_enable_pads[]
https://review.coreboot.org/c/coreboot/+/76925/comment/a8a1cb7f_fbb80a75 : PS5, Line 52: PAD_CFG_GPO(GPP_R7, 0, DEEP), /* BEEP_EN */ I suggest that move BEEP_EN to board override brya board_id0_1_overrides[] = {
https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/changes/25/76925...
https://review.coreboot.org/c/coreboot/+/76925/comment/794a0365_926bd723 : PS5, Line 156: if (fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S))) { add here because the same configuration as MAX98360. || fw_config_probe(FW_CONFIG(AUDIO, NAU8318_NAU88L25B_I2S)
https://review.coreboot.org/c/coreboot/+/76925/comment/ec8f27ff_7f60f6c1 : PS5, Line 164: if (fw_config_probe(FW_CONFIG(AUDIO, NAU8318_NAU88L25B_I2S))) { moving this to line 156.
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/76925/comment/7cf434f3_ea4e793e : PS5, Line 974: register "hid" = "NAU8318" in nau8315 driver, shouldn't the hid = ""NVTN2012""