Attention is currently required from: Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Sridhar Siricilla, Tim Wawrzynczak.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60195 )
Change subject: intel/common/block/cse: Move EOP early in boot sequence
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
This is a good finding but I'm still interested to know why we have to play with sending EOP that many times to find the exact spot where the timing might be optimal. Also, is that guaranteed with all CSE binary in future for ADL and other platforms, we don't need to change the EOP sequence?
Understanding why it's taking longer time is the first thing IMO rather W/A it by moving it earlier or later. Can we pursue our debug in that line ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9c7fe6f8f3fadb68310d4a09692f51f82c737c35
Gerrit-Change-Number: 60195
Gerrit-PatchSet: 2
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Comment-Date: Tue, 21 Dec 2021 04:53:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment