Attention is currently required from: Christian Walter, Arthur Heymans.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74137 )
Change subject: security/tpm: Handle !cbmem case early ......................................................................
Patch Set 1:
(3 comments)
File src/security/tpm/tspi/log-tpm1.c:
https://review.coreboot.org/c/coreboot/+/74137/comment/00192ff8_11a3ecbb PS1, Line 23: if (!cbmem_possibly_online()) Same here
File src/security/tpm/tspi/log-tpm2.c:
https://review.coreboot.org/c/coreboot/+/74137/comment/e6fc9813_91c1e9d7 PS1, Line 44: if (!cbmem_possibly_online()) Same here
File src/security/tpm/tspi/log.c:
https://review.coreboot.org/c/coreboot/+/74137/comment/f164f54d_93b151a4 PS1, Line 15: return NULL; Honestly we can probably drop this check completely, I think it propagated here incorrectly from all the refactorings. This function shouldn't get called from any stages that don't have CBMEM.