Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )
Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280...
File src/southbridge/intel/i82801gx/acpi/globalnvs.asl:
https://review.coreboot.org/c/coreboot/+/43160/4/src/southbridge/intel/i8280...
PS4, Line 18: Offset (0x00)
Sounds good. I think we can drop all `Offset (0x00)` instances, but keep the rest for clarity.
👍
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad9699709f3e90670f2d4f9b5664a048971ea412
Gerrit-Change-Number: 43160
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 01:14:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment