Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35481 )
Change subject: mediatek/mt8183: Clean the calibration result if calibration or mem test fail ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35481/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35481/12//COMMIT_MSG@9 PS12, Line 9: If DRAM calibration fail or mem test fail by using the params store at flash, : should clean the calibration result stored in flash and : trigger system reset to regenerate new calibration params. Please use a text width of 75 characters.
https://review.coreboot.org/c/coreboot/+/35481/12/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35481/12/src/soc/mediatek/mt8183/dr... PS12, Line 1970: dramc_show("system is going to reboot due to DRAM calibration fail.\n"); Please further rephrase. Maybe:
Rebooting system due to wrong calibration data
Rebooting system due to failed calibration
https://review.coreboot.org/c/coreboot/+/35481/12/src/soc/mediatek/mt8183/me... File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/35481/12/src/soc/mediatek/mt8183/me... PS12, Line 50: "memory test fail.\n"); Maybe:
Rebooting system due to failed memory test