Ariel Otilibili has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85778?usp=email )
Change subject: qualcomm/common: Remove dead code ......................................................................
qualcomm/common: Remove dead code
fb_off is set to zero, meaning the else branch is never called.
Coverity-ID: 1469336 Fixes: 3b4c45efa2 ("sc7180: Add display hardware pipe line initialization") Cc: Jonathon Hall jonathon.hall@puri.sm Cc: Yidi Lin yidilin@google.com Cc: Varshit Pandya pandyavarshit@gmail.com Cc: Elyes Haouas ehaouas@noos.fr Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Signed-off-by: Ariel Otilibili otilibil@eurecom.fr --- M src/soc/qualcomm/common/display/mdss.c 1 file changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/85778/1
diff --git a/src/soc/qualcomm/common/display/mdss.c b/src/soc/qualcomm/common/display/mdss.c index a1c13ee..0a7a29d 100644 --- a/src/soc/qualcomm/common/display/mdss.c +++ b/src/soc/qualcomm/common/display/mdss.c @@ -21,13 +21,8 @@ out_size = img_size; stride = (edid->mode.ha * edid->framebuffer_bits_per_pixel/8);
- if (!fb_off) { /* left */ - dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder; - src_xy = dst_xy; - } else { /* right */ - dst_xy = (edid->mode.vborder << 16); - src_xy = (edid->mode.vborder << 16) | fb_off; - } + dst_xy = (edid->mode.vborder << 16) | edid->mode.hborder; + src_xy = dst_xy;
printk(BIOS_INFO, "%s: src=%x fb_off=%x src_xy=%x dst_xy=%x\n", __func__, out_size, fb_off, src_xy, dst_xy);