Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36143 )
Change subject: arch/x86/boot.c: Pass arguments when running programs
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36143/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36143/9//COMMIT_MSG@10
PS9, Line 10: Stages could make use of an argument passed on the stack.
fwiw, x86-64 abi is not using the stack. It's using the sys-v calling convention of passing things through registers.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0f44e9e1992221e02c49d0492cdd2a3d9013560
Gerrit-Change-Number: 36143
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 21:05:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment