Attention is currently required from: Angel Pons, Patrick Rudolph. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59523 )
Change subject: nb/intel/sandybridge/romstage.c: Configure DPR and initialize TXT ......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/sandybridge/romstage.c:
https://review.coreboot.org/c/coreboot/+/59523/comment/c7a0d5f4_54679108 PS2, Line 78: #if CONFIG(INTEL_TXT)
use if(CONFIG(INTEL_TXT)) {
But then if INTEL_TXT is not selected in the configuration, the intel_txt_romstage_init will not have any implementation. Are you fine with an empty __weak intel_txt_romstage_init in this file?
Or alternatively we may always compile the romstage part of TXT driver. If MLE will not set up, we should not hit the situation when there is a TXT wake error and TPM establishment asserted. ACM doesn't have to be included because there would be no need for SCLEAN if I am deducting correctly.