Attention is currently required from: Angel Pons, Felix Singer, Julius Werner, Lean Sheng Tan, Nico Huber.
Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/83615?usp=email )
Change subject: util/cbfstool/cbfs-payload-linux: Do not compress bzImage ......................................................................
Patch Set 4:
(3 comments)
File util/cbfstool/cbfs-payload-linux.c:
https://review.coreboot.org/c/coreboot/+/83615/comment/9a3d8fde_b4c7a7d0?usp... : PS4, Line 58: }
This shouldn't get lost.
Right. I moved the error handling out of `bzp_init` in the latest patchset. I will probably move the error handling to `bzp_output_segment` in CB:83617 since it is the only place where we actually use the compression function.
https://review.coreboot.org/c/coreboot/+/83615/comment/00238104_81d6902f?usp... : PS4, Line 180: * size (ie. incompressible data)?
Does this still make sense?
That is being dealt with in the last patch of the patchtrain.
https://review.coreboot.org/c/coreboot/+/83615/comment/803eb819_dc2ffff7?usp... : PS4, Line 190:
I'd do the compression_function() lookup here, right away. […]
I did that before, but I need the `algo` parameter in `bzp_output_segment` because I need to set the compression attribute of the segment to `algo`. And it seemed overkill to give `bzp_output_segment` both the algorithm as well as the compression function as argument.