Attention is currently required from: Ashish Kumar Mishra, Cliff Huang, Felix Held, Jérémy Compostella, Paul Menzel, Pranava Y N, Saurabh Mishra.
Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83419?usp=email )
Change subject: mb/google/fatcat: Add Panther Lake SOC support ......................................................................
Patch Set 180:
(11 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/83419/comment/e057084f_ed010f5f?usp... : PS180, Line 25: select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC why we are disabling EC sync ? if we need to disable EC sync then please move this into line 75 and add a TODO with a bug to reenable it
https://review.coreboot.org/c/coreboot/+/83419/comment/cdccfb52_0f8ae856?usp... : PS180, Line 40: select DRIVERS_INTEL_PMC why not at common ?
https://review.coreboot.org/c/coreboot/+/83419/comment/62c1feba_e1dfc318?usp... : PS180, Line 42: select DRIVERS_SOUNDWIRE_ALC722 this should go as part of HDA CL ? why not at common ?
https://review.coreboot.org/c/coreboot/+/83419/comment/afa21ea6_45132617?usp... : PS180, Line 50: select SOC_INTEL_PANTHERLAKE_U_H should be in common as well
https://review.coreboot.org/c/coreboot/+/83419/comment/6fb552c3_9ae57395?usp... : PS180, Line 51: select SOC_INTEL_TCSS_USE_PDC_PMC_USBC_MUX_CONFIGURATION this should be in common as well
https://review.coreboot.org/c/coreboot/+/83419/comment/bc015389_3c4051e9?usp... : PS180, Line 61: select HAVE_X86_64_SUPPORT : select USE_X86_64_SUPPORT why are we selecting it again when PTL SoC already selects the same?
https://review.coreboot.org/c/coreboot/+/83419/comment/10800a8d_058affb6?usp... : PS180, Line 75: use tab ?
https://review.coreboot.org/c/coreboot/+/83419/comment/04ee5734_c7b9bc8f?usp... : PS180, Line 75: GBB_FLAG_FORCE_DEV_BOOT_LEGACY why we need this ?
File src/mainboard/google/fatcat/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/83419/comment/1156b733_36320fca?usp... : PS180, Line 32: one tab less and all below lines as well
File src/mainboard/google/fatcat/variants/baseboard/fatcat/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/83419/comment/3d32da24_bab81f0c?usp... : PS180, Line 3: end can you please keep the basic and default device entries here ? like IGD, PMC etc. follow other platforms like Rex baseboard code.
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/83419/comment/da7f5737_eca12299?usp... : PS180, Line 49: CROS_GPIO_DEVICE0_NAME why `DEVICE0` ?