Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 27:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35427/26//COMMIT_MSG@10 PS26, Line 10:
not sure if this is really necessary; one can look up on the vendors site
will be done in a follow up CR that reworks both documentation (already actively working on it)
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssm-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 37: Tianocore
TianoCore
will be done in a follow up CR that reworks both documentation (already actively working on it)
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 64: SATA
S-ATA ports?
see above
https://review.coreboot.org/c/coreboot/+/35427/26/Documentation/mainboard/su... PS26, Line 66: - Super I/O initialisation
?? this is mostly copied from x11ssh-tf
Done
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/35427/25/src/mainboard/supermicro/x... PS25, Line 25: // probably can be removed here
Seems so, yes; x11ssh crashes, x11ssm does not
Done