Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33433 )
Change subject: mainboard/facebook/fbg1701: Configure TC358860 eDP to MIPI controller ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... File src/mainboard/facebook/fbg1701/mainboard.h:
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... PS4, Line 167: { 5, 0x00, 0x00, {0x00, 0x00, 0x00, 0x00, 0x00 } }, maybe add a comment to this line, that this is for detecting the last entry of the array. Had to look twice to see that there's no bug in the code using this
https://review.coreboot.org/#/c/33433/4/src/mainboard/facebook/fbg1701/mainb... PS4, Line 315: { 5, 0x68, 0x01, {0x54, 0x01, 0x00, 0x00, 0x00 } }, the dummy entry in this array to detect the end of the array is missing here