Stefan Reinauer (stefan.reinauer@coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/9480
-gerrit
commit 231d2ca6c611dc9df030e4448bde8155ecb56b27 Author: Kevin L Lee kevin.l.lee@intel.com Date: Fri Dec 12 14:02:43 2014 +0800
baytrail:fix the coding error on PCIe L1 exit lantency
The original code use L1EXIT_MASK to shift the bit for PCIe L1 exist lantency, the code should be use L1EXIT_SHIFT for bit shift.
BUG=chrome-os-partner:34037 BRANCH=None TEST=build and boot on candy, verify B0:D28:F0 + 4Ch [17:15] set to 010b. Correspond WIFI device performance got improvement. Signed-off-by: Kevin L Lee kevin.l.lee@intel.com
Change-Id: I3ac5b6319b726aa16cdb9678face89022d979517 Signed-off-by: Stefan Reinauer reinauer@chromium.org Original-Commit-Id: 381827e3d92c9e786cd8ebe412586968662fb4be Original-Change-Id: I8171f80720830cfa76f26778ae31c7590a723b92 Original-Reviewed-on: https://chromium-review.googlesource.com/234673 Original-Reviewed-by: Kenji Chen kenji.chen@intel.com Original-Reviewed-by: Shawn Nematbakhsh shawnn@chromium.org Original-Tested-by: Kenji Chen kenji.chen@intel.com Original-Commit-Queue: Kenji Chen kenji.chen@intel.com --- src/soc/intel/baytrail/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/intel/baytrail/pcie.c b/src/soc/intel/baytrail/pcie.c index 1870158..e44ebc6 100644 --- a/src/soc/intel/baytrail/pcie.c +++ b/src/soc/intel/baytrail/pcie.c @@ -95,7 +95,7 @@ static void byt_pcie_init(device_t dev) /* Exit latency configuration based on * PHYCTL2_IOSFBCTL[PLL_OFF_EN] set in root port 1*/ REG_PCI_RMW32(LCAP, ~L1EXIT_MASK, - 2 << (L1EXIT_MASK + pll_en_off)), + 2 << (L1EXIT_SHIFT + pll_en_off)), REG_SCRIPT_NEXT(init_static_after_exit_latency), /* Disable hot plug, set power to 10W, set slot number. */ REG_PCI_RMW32(SLCAP, ~(HPC | HPS),