Harshit Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44159 )
Change subject: soc/intel/apollolake: Select ASAN_IN_ROMSTAGE ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44159/1/src/soc/intel/apollolake/Kc... File src/soc/intel/apollolake/Kconfig:
https://review.coreboot.org/c/coreboot/+/44159/1/src/soc/intel/apollolake/Kc... PS1, Line 108: select ASAN_IN_ROMSTAGE if ASAN_IN_RAMSTAGE
You select ASAN_IN_RAMSTAGE elsewhere and suddenly the romstage's behavior changes? I'm not sure I l […]
Instead of having three config options (ASAN, ASAN_IN_RAMSTAGE & ASAN_IN_ROMSTAGE), I thought of creating just two where ASan in ramstage is enabled by default for all platforms when ASan is selected from config menu. And once it is selected, we can enable ASan in romstage on the platforms for which we have done testing. What do you propose?