[coreboot-gerrit] [L] Change in coreboot[master]: [RFC] drivers/option: Add option list in cbtable

[Benjamin Doron (Code Review)]

Attention is currently required from: Angel Pons, Maximilian Brune.

Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )

Change subject: [RFC] drivers/option: Add option list in cbtable
......................................................................

Patch Set 1:

(1 comment)

File src/drivers/option/cfr.c:

https://review.coreboot.org/c/coreboot/+/74121/comment/eced229c_f4aebe8f 
PS1, Line 22: 		/* TODO: error handling? */
            : 		die("%s: bad size (start = %" PRIxPTR ", end = %" PRIxPTR ")",
            : 			__func__, start, end);
            : 
Should we remove this record from the list by returning 0? Then, `lb_new_record()` will find this same memory region for another record. One possible problem is that I don't know what the effect of `header->table_entries++;` would be.

CFR is a feature, it's not critical to the boot. I think if we can keep the platform safe, warning the developer is sufficient. It'll be a little broken, but they'll fix it. Especially since some us primarily use/used the cbmem console and other in-memory debugging services.