Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73449 )
Change subject: cbfstool/default-x86.fmd: Rename BIOS -> SI_BIOS ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Is this a good idea? The SI prefix seems to be applied to mostly Intel boards. The default is BIOS everywhere else. Why should the default FMAP name change?
I changed the FMAP name because if I use the name "BIOS" for validation in the ifdtool, then it will break all FMAPs that actually use the name "SI_BIOS" (almost all mainboards in the tree use it). If I use SI_BIOS on the other hand it will break the default-x86.fmd. So there is currently no way to validate the BIOS region if we use the default-x86.fmd. The easiest alternative that comes to mind is adding a default-intel.fmd file, but that feels wrong considering that we would only create it because of the bios region name. Any ideas on how to resolve this?
I also don't understand this: how could the auto-generated region match what ifdtool --validate expects? I guess it would only work with specific, manual configurations.
You are right. Most of the time the BIOS region will not match. Guess we either need to validate the BIOS region differently (e.g. checking that the BIOS FMAP region fits in the SI_BIOS IFD region) or do not validate it at all.
I tested it in my setup, but unlucky enough I chose a very big CBFS_SIZE because I wanted to stuck a Linux kernel in it. That resulted in a matching BIOS region. And we have no defconfig in the tree that actually selects the VALIDATE_INTEL_DESCRIPTOR option therefore jenkins didn't complain either.