Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35427 )
Change subject: mb/supermicro/x11: add x11ssm-f board ......................................................................
Patch Set 14:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... File Documentation/mainboard/supermicro/x11-lga1151-series/x11ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/13/Documentation/mainboard/su... PS13, Line 38: - After S5 resume coreboot detects more DIMMs than installed, causing FSP-M to fail.
that's already fixed on SSH-TF
according to Documentation/mainboard/supermicro/x11-lga1151-series/x11ssh-f/x11ssh-tf.md it isn't
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... File Documentation/mainboard/supermicro/x11/ssm-f/x11ssh-tf.md:
https://review.coreboot.org/c/coreboot/+/35427/8/Documentation/mainboard/sup... PS8, Line 12: [Intel FSP2.0] can not be removed as long as there is no free replacement
This is basically "FSP 2. […]
both say actually the same...
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssm-f/Kconfig:
https://review.coreboot.org/c/coreboot/+/35427/13/src/mainboard/supermicro/x... PS13, Line 3: config VARIANT_DIR
should be part of the baseboard Kconfig
why? it's only needed when x11ssm is selected