Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43980 )
Change subject: soc/intel/tigerlake: Configure TCSS D3Hot and D3Cold ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43980/4/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43980/4/src/soc/intel/tigerlake/fsp... PS4, Line 120: if (cpu_id == CPUID_TIGERLAKE_A0) : params->D3ColdEnable = 0; Do we still need this condition which we don't need eventually? I thought devicetree change with TcssD3ColdDisable should handle this for only few varient with Ax version.