Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Jon Murphy, Martin Roth, Matt DeVillier, Raul Rangel, Tim Van Patten.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75584?usp=email )
Change subject: soc|vc/amd/phoenix: Prepare for PSP verstage
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/phoenix/psp_verstage/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/75584/comment/6c7f627e_7f12a510 :
PS1, Line 3: ifeq ($(CONFIG_VBOOT_STARTS_BEFORE_BOOTBLOCK),y)
vboot_separate_verstage can also run on the x86, and we don't want this included there. […]
Done. Kept it similar to Mendocino. The only difference is this is including src/vendorcode/amd/fsp/common/include
File src/vendorcode/amd/fsp/phoenix/include/bl_uapp/bl_errorcodes_public.h:
https://review.coreboot.org/c/coreboot/+/75584/comment/2e5a211d_fba9ef17 :
PS1, Line 1: *
Use the version in vendorcode/amd/fsp/common/bl_uapp instead?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75584?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6fbb1f835ac2ad6ff47f843321e1bd380af7ce33
Gerrit-Change-Number: 75584
Gerrit-PatchSet: 3
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 10 Jun 2023 01:12:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment