Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48694 )
Change subject: mb/prodrive/hermes: Update USB 2.0 settings
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48694/2/src/mainboard/prodrive/herm...
File src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/48694/2/src/mainboard/prodrive/herm...
PS2, Line 109: [10] = HERMES_USB2_CONFIG(OC_SKIP), /* BMC */
: [11] = USB2_PORT_EMPTY,
: [12] = HERMES_USB2_CONFIG(OC_SKIP), /* piggy-back */
: [13] = HERMES_USB2_CONFIG(OC_SKIP), /* M.2 key E */
yes, all ports should use HERMES_USB2_CONFIG.
Ack, thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48694
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0dafab88d8dcc05388b724f6a7183c13ac64934
Gerrit-Change-Number: 48694
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-Comment-Date: Mon, 21 Dec 2020 14:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
Gerrit-MessageType: comment