Nicholas Sudsgaard has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84414?usp=email )
Change subject: mb/google: Correct number of jacks in hda_verb.c ......................................................................
mb/google: Correct number of jacks in hda_verb.c
This was found due to the `_Static_assert()` from CB:84360 failing.
Change-Id: Id377281af310642a6ba77e5a0002ca1dfca38827 Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com --- M src/mainboard/google/beltino/variants/monroe/hda_verb.c M src/mainboard/google/link/hda_verb.c 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/84414/1
diff --git a/src/mainboard/google/beltino/variants/monroe/hda_verb.c b/src/mainboard/google/beltino/variants/monroe/hda_verb.c index 064bebf..fc0e631 100644 --- a/src/mainboard/google/beltino/variants/monroe/hda_verb.c +++ b/src/mainboard/google/beltino/variants/monroe/hda_verb.c @@ -6,7 +6,7 @@ /* coreboot specific header */ 0x10ec0283, // Codec Vendor / Device ID: Realtek ALC283 0x10ec0283, // Subsystem ID - 0x0000000e, // Number of jacks (NID entries) + 16, // Number of jacks (NID entries)
0x0017ff00, // Function Reset 0x0017ff00, // Double Function Reset diff --git a/src/mainboard/google/link/hda_verb.c b/src/mainboard/google/link/hda_verb.c index 9381b57..a5cc363 100644 --- a/src/mainboard/google/link/hda_verb.c +++ b/src/mainboard/google/link/hda_verb.c @@ -6,7 +6,7 @@ /* coreboot specific header */ 0x11020011, // Codec Vendor / Device ID: Creative CA0132 0x10280550, // Subsystem ID - 0x00000014, // Number of jacks + Number of Malcolm setup blocks. + 21, // Number of jacks + Number of Malcolm setup blocks.
/* Malcolm Setup */